Skip to content

docs: Document how to ship OTEL traces #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2025
Merged

docs: Document how to ship OTEL traces #753

merged 5 commits into from
Aug 14, 2025

Conversation

sbernauer
Copy link
Member

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Aug 4, 2025
@sbernauer sbernauer requested a review from a team August 4, 2025 14:16
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 4, 2025
@sbernauer sbernauer mentioned this pull request Aug 4, 2025
Merged
20 tasks
NickLarsenNZ
NickLarsenNZ reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably hold off this one until we support config overrides.

Apologies if this had already been discussed and agreed on.

@sbernauer
Copy link
Member Author

I see your point, on the other hand I don't think we will get configOverrides in the next year or two 🙈
Reason is that the usual BTreeMap<String, String> approach doesn't work for the json config of OPA.
Would you also hold off that long?

adwk67
adwk67 reviewed Aug 8, 2025
View reviewed changes
@sbernauer @adwk67
Apply suggestions from code review
96a5db1 
Co-authored-by: Andrew Kenworthy <[email protected]>
sbernauer
sbernauer commented Aug 11, 2025
View reviewed changes
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 11, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Aug 14, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 14, 2025
Merged via the queue into main with commit 12ec57b Aug 14, 2025
17 checks passed
@sbernauer sbernauer deleted the docs/otel branch August 14, 2025 05:57
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@adwk67 adwk67 Awaiting requested review from adwk67

Assignees

@sbernauer sbernauer

Labels
release/25.11.0
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @adwk67 @NickLarsenNZ @lfrancke